fix: injectQuery check with double slash in the url #14910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
added
the
p3-minor-bug
patak-dev
commented
Nov 8, 2023
| str().overwrite( | ||
| start, | ||
| end, | ||
| `__vite__injectQuery(${url}, 'import')`, | ||
| `__vite__injectQuery(${rawUrl}, 'import')`, |
There was a problem hiding this comment.
I think this should still work (as // comments should end up with a new line because they are wrapped in the import(...) call), and it is better to avoid removing the comments, for example in case other plugins are checking for @vite-ignore.
It is also interesting that @vite-ignore here can't be completely ignored, the import query needs to be injected dynamically even if it is used.
bluwy
reviewed
Nov 9, 2023
bluwy
approved these changes
Nov 9, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5051
Description
The currently used regex will fail if there is a double slash in the URL
What is the purpose of this pull request?