chore: rename to BaseEnvironment #16797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ArnaudBarre
force-pushed
the
v6/environment-api-base-env
branch
from
925d880
to
5d9bfd9
Compare
ArnaudBarre
force-pushed
the
v6/environment-api-base-env
branch
from
5d9bfd9
to
673e22c
Compare
patak-dev
reviewed
May 23, 2024
| [...environment].reduce((acc, c) => acc + c.charCodeAt(0), 0) % | ||
| environmentColors.length | ||
| const infoColor = environmentColors[colorIndex || 0] | ||
| this.logger = { |
There was a problem hiding this comment.
I think we should keep this one lazy as it was before so it is cheaper to create the PartialEnvironment if we don't end up using the logger
There was a problem hiding this comment.
I can get it back, but I think this is fine, we will only create this PartialEnvironment a few times in testing and at runtime the logger will probably be used every time
There was a problem hiding this comment.
Ok, let's merge it as is and we can later on bring it back if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.