Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update esbuild #18173

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

Nemikolh
Copy link
Contributor

Description

This PR updates esbuild to 0.24.0 which is needed to fix stackblitz/webcontainer-core#1310 for good (note that in the meantime one can add an overrides or resolutions field to their package.json to pick up that newer version of esbuild.

For the curious, the underlying issue was a bug in the Go compiler: golang/go#65571.

Important changes coming with this release

  • In version 0.22.0, go (and thus esbuild) dropped support for the following operating system:
    • Windows 7
    • Windows 8
    • Windows Server 2008
    • Windows Server 2012
  • In version 0.24.0, go (and thus esbuild) dropped support for the following operating system:
    • macOS 10.15 Catalina (now requires macOS 11 Big Sur or later)

Copy link

stackblitz bot commented Sep 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

/ecosystem-ci run

@patak-dev
Copy link
Member

@bluwy @sapphi-red do you think we can get this backported to the v5 branch? I think we could release a v5.5 minor for this (but without doing any announcements).

@bluwy
Copy link
Member

bluwy commented Sep 23, 2024

Isn't dropping OS support a breaking change? I know that we accept esbuild breaking changes sometimes, but this seems big enough that affected users can only workaround this by pinning the vite version.

@Nemikolh
Copy link
Contributor Author

@bluwy Reading https://go.dev/doc/go1.20#windows and https://go.dev/doc/install/source#environment, I'm starting to wonder if there was a miss-interpretation from my part. As in support got dropped to "run" the go compiler on those platforms as opposed to target them. In which case, there wouldn't be any impact here.

That said, I don't have any Windows 8 or mac with macOS 10.15 Catalina or older to verify this hypothesis.

@sapphi-red
Copy link
Member

I think we can't do it for the reasons bluwy said.


@Nemikolh
It seems to be both "run" and "target": https://stackoverflow.com/questions/76994760/go-1-21-windows-compatibility
For example, this commit (golang/go@f0894a0) that breaks Windows 8 and lower is included in Go 1.22+.

@patak-dev
Copy link
Member

Thanks for the insights @bluwy @sapphi-red 🙏🏼
Let's merge this for the vite 6 beta then

@patak-dev patak-dev merged commit e59e2ca into vitejs:main Sep 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: panic: runtime error: slice bounds out of range
4 participants