Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn about dynamic import polyfill only during build #3446

Merged
merged 2 commits into from
May 17, 2021
Merged

fix: warn about dynamic import polyfill only during build #3446

merged 2 commits into from
May 17, 2021

Conversation

patak-dev
Copy link
Member

Description

Since we are enabling the dynamic import polyfill only during build, we can not reliably warn about an unneeded import 'vite/dynamic-import-polyfill'. We can also not detect the legacy plugin, since the user may want to enable this plugin only without the full legacy build. This PR removes this warning. See related discussion in #3434


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

antfu
antfu previously approved these changes May 17, 2021
@patak-dev patak-dev changed the title fix: remove dynamic import polyfill warning fix: warn about dynamic import polyfill only during build May 17, 2021
@patak-dev
Copy link
Member Author

We can actually safely warn during build, I restored the warning with this check

@patak-dev patak-dev requested a review from antfu May 17, 2021 09:08
@antfu antfu merged commit 5fe0550 into vitejs:main May 17, 2021
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants