Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: surface package resolution failures #4822

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

benmccann
Copy link
Collaborator

@benmccann benmccann commented Sep 2, 2021

Description

Currently exceptions are being swallowed, which makes it quite hard to tell what is going wrong

Additional context

I was able to find out what was going wrong by debugging, but this would save effort in the future


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92
Copy link
Member

I assume you can use our logger

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Sep 2, 2021
@Shinigami92 Shinigami92 self-requested a review September 2, 2021 17:46
@patak-dev
Copy link
Member

The logger is available in config: ResolvedConfig that is in scope. See

config.logger.error(`${chalk.red(`http proxy error:`)}\n${err.stack}`, {

@benmccann
Copy link
Collaborator Author

thanks for the pointer! updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants