fix(css): convert map returned by vite:css transform to SourceMap (fixes #4939) #4950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #4939)
Description
the map returned by postcss can be a SourceMapGenerator. Use a function to check and call toJSON() on it.
additionally throw an error if the returned map is not something we can pass on as part of the transform result.
An alternate solution would be to roll back the offending commit as this change would not lead to satisfactory sourcemap support on it's own and getting it done isn't a short term endeavor
Additional context
I wasn't able to come up with a testcase for this due to that fact that this map isn't turning up in any results. vite css sourcemaps are completely broken at the moment, especially for bundled and minified output a lot of things need to be added.
there is an old enhancement ticket about it #2830 maybe it's time to revisit that someday
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).