Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: importing ts files using their corresponding js extesions #5510

Merged
merged 4 commits into from
Nov 2, 2021
Merged

feat: importing ts files using their corresponding js extesions #5510

merged 4 commits into from
Nov 2, 2021

Conversation

haoqunjiang
Copy link
Member

Description

To align with tsc default behavior, mentioned in microsoft/TypeScript#46452

Fixes #3040

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Nov 2, 2021
@patak-dev patak-dev changed the title feat: support importing ts files using their corresponding js extesions feat: importing ts files using their corresponding js extesions Nov 2, 2021
@patak-dev patak-dev merged commit 7977e92 into vitejs:main Nov 2, 2021
@Niputi Niputi mentioned this pull request Nov 3, 2021
Closed
7 tasks
@haoqunjiang haoqunjiang mentioned this pull request Nov 10, 2021
Closed
@patak-dev patak-dev mentioned this pull request Nov 27, 2021
Closed
@renke renke mentioned this pull request Dec 8, 2021
Closed
4 tasks
@dashavoo dashavoo mentioned this pull request Jan 28, 2022
Closed
7 tasks
@AndrewLeedham AndrewLeedham mentioned this pull request Feb 11, 2022
Closed
7 tasks
@tajo tajo mentioned this pull request Mar 8, 2022
Closed
7 tasks
@wight554 wight554 mentioned this pull request Apr 26, 2022
Closed
7 tasks
@duaneatat duaneatat mentioned this pull request May 24, 2022
Merged
@NatoBoram NatoBoram mentioned this pull request Jul 6, 2022
Closed
@frank-weindel frank-weindel mentioned this pull request Jan 25, 2023
Closed
7 tasks
@aaronadamsCA aaronadamsCA mentioned this pull request Aug 18, 2024
Closed
4 tasks
@sapphi-red sapphi-red mentioned this pull request Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing a .js typescript resource from a typescript file fails
3 participants
@haoqunjiang @patak-dev @Shinigami92