Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commonjsOptions): expose ignoreTryCatch config #5555

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

cassiozen
Copy link
Contributor

Description

#5173 Updated @rollup/plugin-commonjs to 21 (with a new default value for ignoreTryCatch)

This is a safer option, but it is a breaking change for some projects (as mentioned here).

This PR merely exposes the ignoreTryCatch configuration type under commonjsOptions, so broken projects can decide to revert to the previous behavior.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@patak-dev patak-dev merged commit d383c2a into vitejs:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants