Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): skip dedupe require in esm #5714

Merged
merged 3 commits into from
Nov 17, 2021

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 17, 2021

Description

The dedupeRequire function injected in the build only works in CJS, so we exclude it if we're building for ESM.

Additional context

Caused by #3951. (cc @aleclarson) I've confirmed this fixes the build tests in vite-plugin-svelte.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 9666446 into vitejs:main Nov 17, 2021
@bluwy bluwy deleted the fix-dedupe-require-esm branch November 17, 2021 07:29
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants