Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): skip dedupe require if noExternal true #5928

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 2, 2021

Description

Fix #5812

If noExternal is true, there's no need to dedupe any dependencies as everything is already bundled (and deduped by rollup)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Dec 2, 2021
@patak-dev patak-dev merged commit f6aa7fe into vitejs:main Dec 2, 2021
@bluwy bluwy deleted the skip-dedupe-require-noexternal branch December 2, 2021 12:31
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite 2.7.0-beta.4 regression when building for SSR targeting Cloudflare Workers
4 participants