Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overwrite plugin-vue define with user define option #6072

Merged
merged 4 commits into from
Dec 12, 2021
Merged

fix: overwrite plugin-vue define with user define option #6072

merged 4 commits into from
Dec 12, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Dec 11, 2021

Description

fix #5967

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix that issue, overwriting the two fields defined in this plugin would suffice.
Spreading the whole define object would reintroduce the bug described in #5150

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Dec 11, 2021

For an issue like #5150, I have opened #6052. But yeah only overwriting those two properties is better.

packages/plugin-vue-jsx/index.js Outdated Show resolved Hide resolved
@haoqunjiang haoqunjiang merged commit 5f3f6b7 into vitejs:main Dec 12, 2021
@ydcjeff ydcjeff deleted the fix/5967 branch December 12, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@vitejs/plugin-vue not merge feature flag __VUE_PROD_DEVTOOLS__ from vite config
3 participants