feat(config): esbuild minify configurable

[poyoho]

Description

fix #6065

Additional context

esbuild minify configurable

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[ydcjeff]

@poyoho Please change fix: #5619, #6065 to

fix #5619
fix #6065

so that it will close those 2 issues once this PR is merged

[bluwy]

I'm not really sure if we want to support this. IMO it deviates from Vite's opinion, and the two issues are trying to solve a very niche edge-case. #5619 seems like it would be better fixed on esbuild side. #6065 is weird that it wants to disable a specific part of minification. I bet it can be solved by refactoring the core problem.

[poyoho]

yes, #5619 is better fixed on esbuild side. now vite can only set CSS to need minify by default.
but #6065 I guess he wants to configure the parameter of esbuild minify, but vite ignored minify config.userConfig should have a higher priority?

[kskalski]

Right now vite.config.js's

  esbuild: {
    minify: false
  }

is ignored and esbuild is still being used for minification, which contradicts documentation at https://vitejs.dev/config/#build-minify
In my opiion user config options from vite.config.js should definitely take priority

[poyoho]

However, in most cases, the internal configuration of vite has a higher priority.🙈

[kskalski]

However, in most cases, the internal configuration of vite has a higher priority.🙈

Could you clarify if this is current / desired / documented behavior?

[poyoho]

IIUC, @patak-dev said in my other PR. So I closed this PR because it violated the rules