Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): skip vite resolve for windows absolute path #6764

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Feb 5, 2022

Description

When hookNodeResolve encounters path like C:/foo/bar or D:\\foo\\bar, skip viteResolve too.

Additional context

Follow-up from #6488. Reported by @natemoo-re from discord. No tests since we haven't really had tests for this feature, but I think it's fine with #6591 coming.

I initially planned to modify bareImportRE instead, but handling it there generically may cause breaking changes in other places, so I resorted to the changes here now.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority) labels Feb 5, 2022
@patak-dev patak-dev merged commit 489a7f1 into vitejs:main Feb 5, 2022
@bluwy bluwy deleted the fix-vite-resolve-windows branch February 5, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants