Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restart optimize #7004

Merged
merged 3 commits into from
Mar 3, 2022
Merged

fix: restart optimize #7004

merged 3 commits into from
Mar 3, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Feb 20, 2022

Description

When calling server.restart(true), properly restart the vite dev server.

Additional context

I was developing a vite plugin using this function when I found it doesn't work correctly. Turns out when we instantiate a new server during server restart, the new server doesn't contain the old metadata to tell whether we should force optimize.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 20, 2022
@patak-dev patak-dev added this to the 2.9 milestone Feb 20, 2022
@bluwy bluwy mentioned this pull request Feb 20, 2022
9 tasks
@patak-dev patak-dev merged commit 47fbe29 into vitejs:main Mar 3, 2022
@bluwy bluwy deleted the fix-restart-optimize branch March 5, 2022 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants