-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve @import of the proxied <style> #7031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygj6
added
p3-minor-bug
An edge case that only affects very specific usage (priority)
regression
The issue only appears after a new release
labels
Feb 22, 2022
ygj6
changed the title
fix: avoid resolve @import from html proxy <style>
fix: resolve @import of the proxied <style>
Feb 22, 2022
patak-dev
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @poyoho would you help reviewing this PR?
7 tasks
poyoho
reviewed
Feb 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
poyoho
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
p3-minor-bug
An edge case that only affects very specific usage (priority)
regression
The issue only appears after a new release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: #6886
After #6321, <style>...</style> content will be converted to a virtual module
vite/packages/vite/src/node/plugins/html.ts
Lines 370 to 383 in 33f9671
... and will be processed by the css plugin.
IIUC, we don't need to resolve@import
from html proxy <style>.We need to resolve public
@import
url from proxied <style>Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).