Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): catch thrown errors when connecting to hmr websocket #7111

Merged
merged 3 commits into from
May 18, 2022

Conversation

JadedBlueEyes
Copy link
Contributor

Description

This fixes #7110 by catching thrown errors in a try block and logging the error.

Note that this just prevents errors from stopping execution, rather than enabling hot reloading to continue to work, even in a degraded capacity.
To have hot reloading continue to work in these contexts, __HMR_HOSTNAME__ must be set and the WebSocket must allow cross-origin connections.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi changed the title fix: Catch thrown errors when connecting to vite-hmr websocket (fix #7110) fix(hmr): Catch thrown errors when connecting to hmr websocket Feb 27, 2022
@bluwy bluwy added feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority) labels Feb 28, 2022
@patak-dev patak-dev changed the title fix(hmr): Catch thrown errors when connecting to hmr websocket fix(hmr): catch thrown errors when connecting to hmr websocket May 18, 2022
@patak-dev patak-dev merged commit 4bc9284 into vitejs:main May 18, 2022
@sapphi-red sapphi-red mentioned this pull request May 20, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite hot reload client code passes malformed URI to new WebSocket in noorigin contexts
5 participants