Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-legacy): respect entryFileNames for polyfill chunks for v2.x.x Vite version. Issue #4221 #8958

Closed

Conversation

lisunovdv
Copy link

Description

It solves the same as #8247 for v2.x.x

Additional context

close #4221
refs #8180


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for vite-docs-v2 ready!

Name Link
🔨 Latest commit f8378d2
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-v2/deploys/62c5c08ea619810008fe4e75
😎 Deploy Preview https://deploy-preview-8958--vite-docs-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lisunovdv lisunovdv changed the title fix(plugin-legacy): respect entryFileNames for polyfill chunks fix(plugin-legacy): respect entryFileNames for polyfill chunks for v2.x.x Vite version Jul 8, 2022
@lisunovdv lisunovdv changed the title fix(plugin-legacy): respect entryFileNames for polyfill chunks for v2.x.x Vite version fix(plugin-legacy): respect entryFileNames for polyfill chunks for v2.x.x Vite version. Issue #4221 Jul 8, 2022
@lisunovdv
Copy link
Author

@patak-dev please, review

@sapphi-red
Copy link
Member

The tests are failing and config.build.entryFileNames does not exist.
I feel this change is a bit risky to backport unless the polyfill chunk names preserve as-is when entryFileNames is not set.

@sapphi-red
Copy link
Member

Closing as we're not going to backport this feature. But thanks for the PR.

@sapphi-red sapphi-red closed this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants