Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ssr #8987

Merged
merged 2 commits into from
Jul 12, 2022
Merged

docs: update ssr #8987

merged 2 commits into from
Jul 12, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 8, 2022

Description

Update docs of ssr not being experimental.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@netlify
Copy link

netlify bot commented Jul 8, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit 653692c
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62c7d19bde1e2d0008837172
😎 Deploy Preview https://deploy-preview-8987--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bluwy bluwy added the documentation Improvements or additions to documentation label Jul 8, 2022
Comment on lines +26 to -32
- **Experimental**
- **Type:** `'esm' | 'cjs'`
- **Default:** `esm`
- **Experimental**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to be consistent with css.devSourcemap

docs/guide/ssr.md Outdated Show resolved Hide resolved
@patak-dev
Copy link
Member

I think we can merge this, if we are going to change how SSR works, it is going to be in the next major. There is no need to have the experimental banners now.

@patak-dev patak-dev merged commit 8c52867 into vitejs:main Jul 12, 2022
@bluwy bluwy deleted the update-docs-ssr branch July 12, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants