Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(config): clarify config esm syntax #9157

Merged
merged 2 commits into from
Jul 21, 2022
Merged

docs(config): clarify config esm syntax #9157

merged 2 commits into from
Jul 21, 2022

Conversation

SteveALee
Copy link
Contributor

Description

Small clarification to config file use of node ESM

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • [#x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy
bluwy reviewed Jul 21, 2022
View reviewed changes
docs/config/index.md Outdated Show resolved Hide resolved
@bluwy bluwy changed the title Small clarification docs: clarify config esm syntax Jul 21, 2022
@bluwy bluwy changed the title docs: clarify config esm syntax docs(config): clarify config esm syntax Jul 21, 2022
@bluwy bluwy enabled auto-merge (squash) July 21, 2022 17:58
@bluwy bluwy merged commit 881050d into vitejs:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveALee @bluwy