Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove vanilla classname small typo fix #9490

Closed
wants to merge 1 commit into from
Closed

remove vanilla classname small typo fix #9490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/create-vite/template-vanilla-ts/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ document.querySelector<HTMLDivElement>('#app')!.innerHTML = `
<img src="/vite.svg" class="logo" alt="Vite logo" />
</a>
<a href="https://www.typescriptlang.org/" target="_blank">
<img src="${typescriptLogo}" class="logo vanilla" alt="TypeScript logo" />
<img src="${typescriptLogo}" class="logo" alt="TypeScript logo" />
Copy link
Contributor

@tony19 tony19 Aug 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right change because removing .vanilla here would give the TypeScript logo the same purplish glow as Vite's logo. The style for .vanilla should be fixed IMO.

The actual color shown appears to be for the yellowish hue for the vanilla JavaScript logo, as seen in the scaffolded style:

.logo.vanilla:hover {
  filter: drop-shadow(0 0 2em #f7df1eaa);
}

And that's strange because the color is the correct bluish hue in:

vite/packages/create-vite/template-vanilla-ts/src/style.css

Lines 55 to 57 in dd40a97

.logo.vanilla:hover {
filter: drop-shadow(0 0 2em #3178c6aa);
}

That to me indicates the actual problem is create-vite is copying over template-vanilla's style.css file instead of the one from template-vanilla-ts.

</a>
<h1>Vite + TypeScript</h1>
<div class="card">
Expand Down