Remove sharding_column_name and sharding_column_type from vtctld2 (#1…

…0459) * Remove sharding_column_name and sharding_column_type Signed-off-by: notfelineit <[email protected]> * Run make web_build to compile production files Signed-off-by: notfelineit <[email protected]> * Remove vars from test Signed-off-by: notfelineit <[email protected]> * Remove sharding column type select box test from web test Signed-off-by: notfelineit <[email protected]>
vitessio · Jun 8, 2022 · 1edcc64 · 1edcc64
1 parent 8316dd5
commit 1edcc64
Show file tree

Hide file tree

Showing 13 changed files with 120 additions and 326 deletions.
diff --git a/go/test/endtoend/vtctldweb/vtctld_web_test.go b/go/test/endtoend/vtctldweb/vtctld_web_test.go
@@ -120,25 +120,10 @@ func TestCreateKs(t *testing.T) {
 			err := ele.SendKeys("test_keyspace3")
 			require.Nil(t, err)
 			assertDialogCommand(t, dialog, []string{"CreateKeyspace", "-force=false", "test_keyspace3"})
-
-		case 1:
-			err := ele.SendKeys("test_id")
-			require.Nil(t, err)
-			assertDialogCommand(t, dialog, []string{"CreateKeyspace", "-sharding_column_name=test_id", "-sharding_column_type=UINT64", "-force=false", "test_keyspace3"})
 		}
 	}
 
-	dropdown, err := dialog.FindElement(selenium.ByTagName, "p-dropdown")
-	require.Nil(t, err)
-
-	click(t, dropdown)
-
-	options, err := dropdown.FindElements(selenium.ByTagName, "li")
-	require.Nil(t, err)
-
-	click(t, options[1])
-
-	assertDialogCommand(t, dialog, []string{"CreateKeyspace", "-sharding_column_name=test_id", "-sharding_column_type=BYTES", "-force=false", "test_keyspace3"})
+	assertDialogCommand(t, dialog, []string{"CreateKeyspace", "-force=false", "test_keyspace3"})
 
 	create, err := dialog.FindElement(selenium.ByID, "vt-action")
 	require.Nil(t, err)
@@ -157,7 +142,7 @@ func TestCreateKs(t *testing.T) {
 	require.Nil(t, err)
 	click(t, menu)
 
-	options, err = testKs[2].FindElements(selenium.ByTagName, "li")
+	options, err := testKs[2].FindElements(selenium.ByTagName, "li")
 	require.Nil(t, err)
 	for _, v := range options {
 		if text(t, v) == "Delete" {

diff --git a/go/vt/vtctld/rice-box.go b/go/vt/vtctld/rice-box.go
diff --git a/web/vtctld2/app/index.html b/web/vtctld2/app/index.html
@@ -27,5 +27,5 @@
 </head>
 <body class="flex-column">
   <vt-app-root class="flex-column flex-grow">Loading...</vt-app-root>
-<script type="text/javascript" src="inline.js"></script><script type="text/javascript" src="styles.38b88af69dfd283498eb.bundle.js"></script><script type="text/javascript" src="main.4f05e5457c6dec67dde5.bundle.js"></script></body>
+<script type="text/javascript" src="inline.js"></script><script type="text/javascript" src="styles.38b88af69dfd283498eb.bundle.js"></script><script type="text/javascript" src="main.bbd046af7028149e10ca.bundle.js"></script></body>
 </html>
diff --git a/web/vtctld2/app/inline.js b/web/vtctld2/app/inline.js
diff --git a/web/vtctld2/app/main.4f05e5457c6dec67dde5.bundle.js.gz b/web/vtctld2/app/main.4f05e5457c6dec67dde5.bundle.js.gz
diff --git a/...2/app/main.4f05e5457c6dec67dde5.bundle.js → ...2/app/main.bbd046af7028149e10ca.bundle.js b/...2/app/main.4f05e5457c6dec67dde5.bundle.js → ...2/app/main.bbd046af7028149e10ca.bundle.js
diff --git a/web/vtctld2/app/main.bbd046af7028149e10ca.bundle.js.gz b/web/vtctld2/app/main.bbd046af7028149e10ca.bundle.js.gz
diff --git a/web/vtctld2/app/styles.38b88af69dfd283498eb.bundle.js b/web/vtctld2/app/styles.38b88af69dfd283498eb.bundle.js
diff --git a/web/vtctld2/app/styles.38b88af69dfd283498eb.bundle.js.gz b/web/vtctld2/app/styles.38b88af69dfd283498eb.bundle.js.gz