minor refactor

Signed-off-by: Harshit Gangal <[email protected]>

go/test/endtoend/vtgate/foreignkey/main_test.go

@@ -35,8 +35,8 @@ var (
 	clusterInstance *cluster.LocalProcessCluster
 	vtParams        mysql.ConnParams
 	shardedKs       = "ks"
-	shardedKsShards = []string{"-19a0", "19a0-20", "20-20c0", "20c0-"}
 	Cell            = "test"
+
 	//go:embed sharded_schema.sql
 	shardedSchemaSQL string
 
@@ -65,12 +65,7 @@ func TestMain(m *testing.M) {
 			VSchema:   shardedVSchema,
 		}
 
-		err = clusterInstance.StartKeyspace(*sKs, shardedKsShards, 0, false)
-		if err != nil {
-			return 1
-		}
-
-		err = clusterInstance.VtctlclientProcess.ExecuteCommand("RebuildVSchemaGraph")
+		err = clusterInstance.StartKeyspace(*sKs, []string{"-80", "80-"}, 0, false)
 		if err != nil {
 			return 1
 		}

go/vt/sqlparser/ast_funcs.go

@@ -2495,8 +2495,8 @@ func (ty KillType) ToString() string {
 	}
 }
 
-// Indexes returns true,
-// if the list of columns contains all the elements in the other list provided along with their indexes.
+// Indexes returns true, if the list of columns contains all the elements in the other list.
+// It also returns the indexes of the columns in the list.
 func (cols Columns) Indexes(subSetCols Columns) (bool, []int) {
 	var indexes []int
 	for _, subSetCol := range subSetCols {

go/vt/vtgate/planbuilder/plan_test.go

@@ -112,7 +112,7 @@ func TestForeignKeyPlanning(t *testing.T) {
 	}
 	testOutputTempDir := makeTestOutput(t)
 
-	testFile(t, "fk_cases.json", testOutputTempDir, vschemaWrapper, false)
+	testFile(t, "foreignkey_cases.json", testOutputTempDir, vschemaWrapper, false)
 }
 
 func TestSystemTables57(t *testing.T) {