Updates per code review

vitessio · Oct 25, 2017 · fbd4a56 · fbd4a56
1 parent 27b0c90
commit fbd4a56
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/go/vt/schemamanager/tablet_executor.go b/go/vt/schemamanager/tablet_executor.go
@@ -153,7 +153,7 @@ func (exec *TabletExecutor) detectBigSchemaChanges(ctx context.Context, parsedDD
 	}
 	for _, ddl := range parsedDDLs {
 		switch ddl.Action {
-		case sqlparser.DropStr, sqlparser.CreateStr:
+		case sqlparser.DropStr, sqlparser.CreateStr, sqlparser.TruncateStr:
 			continue
 		}
 		tableName := ddl.Table.Name.String()

diff --git a/go/vt/schemamanager/tablet_executor_test.go b/go/vt/schemamanager/tablet_executor_test.go
@@ -127,6 +127,12 @@ func TestTabletExecutorValidate(t *testing.T) {
 		t.Fatalf("executor.Validate should fail, change a table more than 2,000,000 rows")
 	}
 
+	if err := executor.Validate(ctx, []string{
+		"TRUNCATE TABLE test_table_04",
+	}); err != nil {
+		t.Fatalf("executor.Validate should succeed, drop a table with more than 2,000,000 rows is allowed")
+	}
+
 	if err := executor.Validate(ctx, []string{
 		"DROP TABLE test_table_04",
 	}); err != nil {