Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin] Rename ERS/PRS pools+flags properly #10460

Merged

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Jun 7, 2022

Description

I missed this when doing #10404 🙈; ideally this lands in 14.0

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@deepthi
Copy link
Member

deepthi commented Jun 7, 2022

ideally this lands in 14.0

You just need to create another PR 😄
General rule for rc1 -> GA timeframe is that any and all bug fixes are allowed. Plus minor changes / cleanups / bug fixes on top of features that are new in the release are certainly allowed.

@ajm188 ajm188 merged commit 85861e9 into vitessio:main Jun 7, 2022
@ajm188 ajm188 deleted the andrew/vtdamin/failover-rename-cleanup branch June 7, 2022 19:49
ajm188 pushed a commit to planetscale/vitess that referenced this pull request Jun 8, 2022
ajm188 pushed a commit that referenced this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants