fix: scalar aggregation engine primitive #10465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <[email protected]>
… scalar aggregation Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
changed the title
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
reviewed
Jun 8, 2022
Comment on lines
+134
to
+141
| dispOrigOp := "" | ||
| if ap.OrigOpcode != AggregateUnassigned && ap.OrigOpcode != ap.Opcode { | ||
| dispOrigOp = "_" + ap.OrigOpcode.String() | ||
| } | ||
| if ap.Alias != "" { | ||
| return fmt.Sprintf("%s(%s) AS %s", ap.Opcode.String(), keyCol, ap.Alias) | ||
| return fmt.Sprintf("%s%s(%s) AS %s", ap.Opcode.String(), dispOrigOp, keyCol, ap.Alias) | ||
| } | ||
| return fmt.Sprintf("%s(%s)", ap.Opcode.String(), keyCol) | ||
| return fmt.Sprintf("%s%s(%s)", ap.Opcode.String(), dispOrigOp, keyCol) |
There was a problem hiding this comment.
I think the plans would be more readable if we had a field that contains the original op code to the description instead of suffixing the original op code to the current op code. I don't have strong opinions though, the current change works well too imo.
frouioui
approved these changes
Jun 8, 2022
harshit-gangal
added a commit
to planetscale/vitess
that referenced
this pull request
Jun 21, 2022
* test: added failing e2e test Signed-off-by: Harshit Gangal <[email protected]> * fix: handle empty row for scalar aggregation and also olap engine for scalar aggregation Signed-off-by: Harshit Gangal <[email protected]> * test: update plan test output Signed-off-by: Harshit Gangal <[email protected]> * test: e2e test for empty rows in non-scalar aggregates Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>
2 tasks
harshit-gangal
added a commit
that referenced
this pull request
Jun 21, 2022
* test: added failing e2e test Signed-off-by: Harshit Gangal <[email protected]> * fix: handle empty row for scalar aggregation and also olap engine for scalar aggregation Signed-off-by: Harshit Gangal <[email protected]> * test: update plan test output Signed-off-by: Harshit Gangal <[email protected]> * test: e2e test for empty rows in non-scalar aggregates Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two bugs in scalar aggregation engine primitive
This was caused when we moved from using AggregateSum over AggregateCount as opcode for count(*). As the actual operation at the engine primitive level was sum of count, this caused a negative effect of returning
NULLfor empty row instead of0.Related Issue(s)
Checklist
Deployment Notes