Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aggregation empty row on join with grouping and aggregations #10480

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Jun 9, 2022

Description

This PR fixes an aggregation-grouping bug in gen4 that does non-scalar aggregates on a top of a join.
This happens when the left side of the join has data and no data is present on the right hand side.
If the right hand side of the join only contains an aggregation then even though the table has no data it will return count(*) as 0 and that will get mapped to the join output.
To avoid such scenario the change adds a grouping condition on the right hand side using literal 1 so that the rows from right hand side is only returned when the join condition matches.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported 14.0
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@harshit-gangal harshit-gangal merged commit 2b59f38 into vitessio:main Jun 9, 2022
@harshit-gangal harshit-gangal deleted the fix-nonscalaraggr-nores branch June 9, 2022 11:42
harshit-gangal added a commit to planetscale/vitess that referenced this pull request Jun 21, 2022
deepthi pushed a commit that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants