Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin] Add authz tests for remaining non-schema related actions #10481

Merged
merged 9 commits into from
Jun 9, 2022
Merged

[vtadmin] Add authz tests for remaining non-schema related actions #10481

merged 9 commits into from
Jun 9, 2022

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Jun 9, 2022

Description

Everything except (Find|Get)Schema, GetSchemas, and VTExplain (which are coming next).

Related Issue(s)

#10397

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Andrew Mason added 9 commits June 8, 2022 18:10
Add authz tests for EmergencyFailoverShard
c019517 
Signed-off-by: Andrew Mason <[email protected]>
Add authz tests for PlannedFailoverShard
1c57c8c 
Signed-off-by: Andrew Mason <[email protected]>
Add ValidateKeyspace to mock vtctld
d23382f 
Signed-off-by: Andrew Mason <[email protected]>
Add authz tests for ValidateKeyspace
5a7dbb3 
Signed-off-by: Andrew Mason <[email protected]>
Add ValidateSchemaKeyspace to mock vtctld
b19bebf 
Signed-off-by: Andrew Mason <[email protected]>
Add authz tests for ValidateSchemaKeyspace
eeb3104 
Signed-off-by: Andrew Mason <[email protected]>
Add ValidateVersionKeyspace to mock vtctld
01ed884 
Signed-off-by: Andrew Mason <[email protected]>
Add authz tests for ValidateVersionKeyspace
c683478 
Signed-off-by: Andrew Mason <[email protected]>
fixup mock data sorting
4511cc5 
Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 added this to the v14.0 milestone Jun 9, 2022
@ajm188 ajm188 requested a review from deepthi June 9, 2022 14:09
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@ajm188 ajm188 changed the title [vtadmin] authz tests misc [vtadmin] Add authz tests for remaining non-schema related actions Jun 9, 2022
@ajm188 ajm188 mentioned this pull request Jun 9, 2022
Merged
3 tasks
@ajm188 ajm188 merged commit 193e799 into vitessio:main Jun 9, 2022
@ajm188 ajm188 deleted the andrew/vtadmin-authz-tests-misc branch June 9, 2022 20:40
ajm188 pushed a commit to planetscale/vitess that referenced this pull request Jun 9, 2022
[vtadmin] Add authz tests for remaining non-schema related actions (v…
9e85039 
…itessio#10481)

* Add authz tests for EmergencyFailoverShard

Signed-off-by: Andrew Mason <[email protected]>

* Add authz tests for PlannedFailoverShard

Signed-off-by: Andrew Mason <[email protected]>

* Add ValidateKeyspace to mock vtctld

Signed-off-by: Andrew Mason <[email protected]>

* Add authz tests for ValidateKeyspace

Signed-off-by: Andrew Mason <[email protected]>

* Add ValidateSchemaKeyspace to mock vtctld

Signed-off-by: Andrew Mason <[email protected]>

* Add authz tests for ValidateSchemaKeyspace

Signed-off-by: Andrew Mason <[email protected]>

* Add ValidateVersionKeyspace to mock vtctld

Signed-off-by: Andrew Mason <[email protected]>

* Add authz tests for ValidateVersionKeyspace

Signed-off-by: Andrew Mason <[email protected]>

* fixup mock data sorting

Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 mentioned this pull request Jun 9, 2022
Merged
3 tasks
deepthi pushed a commit that referenced this pull request Jun 13, 2022
[backport] [vtadmin] Add remaining authz tests (#10487)
cd150b2 
* [vtadmin] Add authz tests for remaining non-schema related actions (#10481)

* Add authz tests for EmergencyFailoverShard

Signed-off-by: Andrew Mason <[email protected]>

* Add authz tests for PlannedFailoverShard

Signed-off-by: Andrew Mason <[email protected]>

* Add ValidateKeyspace to mock vtctld

Signed-off-by: Andrew Mason <[email protected]>

* Add authz tests for ValidateKeyspace

Signed-off-by: Andrew Mason <[email protected]>

* Add ValidateSchemaKeyspace to mock vtctld

Signed-off-by: Andrew Mason <[email protected]>

* Add authz tests for ValidateSchemaKeyspace

Signed-off-by: Andrew Mason <[email protected]>

* Add ValidateVersionKeyspace to mock vtctld

Signed-off-by: Andrew Mason <[email protected]>

* Add authz tests for ValidateVersionKeyspace

Signed-off-by: Andrew Mason <[email protected]>

* fixup mock data sorting

Signed-off-by: Andrew Mason <[email protected]>

* [vtadmin] Add schema-related authz tests (#10486)

* Update template to support more tablet fields

Signed-off-by: Andrew Mason <[email protected]>

* Update template, add full srvvschema payload, add schema payload, add authz tests for VTExplain

Signed-off-by: Andrew Mason <[email protected]>

* Add authz tests for GetSchema

Signed-off-by: Andrew Mason <[email protected]>

* Add authz tests for GetSchemas

Signed-off-by: Andrew Mason <[email protected]>

* Add authz tests for FindSchema

Signed-off-by: Andrew Mason <[email protected]>

* Add authz tests for ReloadSchemas

Signed-off-by: Andrew Mason <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@doeg doeg Awaiting requested review from doeg

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: VTAdmin VTadmin interface Type: Testing
Projects
None yet
Milestone
v14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ajm188 @deepthi