-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix casing of vitess migration syntax and comments printing #10535
Merged
GuptaManan100
merged 1 commit into
vitessio:main
from
planetscale:dbussink/fix-vitess-migration-and-comment-casing
Jun 17, 2022
Merged
Fix casing of vitess migration syntax and comments printing #10535
GuptaManan100
merged 1 commit into
vitessio:main
from
planetscale:dbussink/fix-vitess-migration-and-comment-casing
Jun 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The canonical form of printing the vitess migration syntax would upcase the UUID value, but it needs to be passed through unchanged. This in turn led me to testing comments in a query as well and it turns out we wrongly change the case there as well. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
requested review from
harshit-gangal,
systay and
GuptaManan100
as code owners
June 17, 2022 09:21
GuptaManan100
approved these changes
Jun 17, 2022
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
3 tasks
GuptaManan100
deleted the
dbussink/fix-vitess-migration-and-comment-casing
branch
June 17, 2022 11:42
GuptaManan100
pushed a commit
to planetscale/vitess
that referenced
this pull request
Jun 22, 2022
…#10535) The canonical form of printing the vitess migration syntax would upcase the UUID value, but it needs to be passed through unchanged. This in turn led me to testing comments in a query as well and it turns out we wrongly change the case there as well. Signed-off-by: Dirkjan Bussink <[email protected]>
Merged
3 tasks
GuptaManan100
added a commit
that referenced
this pull request
Jun 22, 2022
…10570) The canonical form of printing the vitess migration syntax would upcase the UUID value, but it needs to be passed through unchanged. This in turn led me to testing comments in a query as well and it turns out we wrongly change the case there as well. Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]>
rsajwani
pushed a commit
to planetscale/vitess
that referenced
this pull request
Jun 27, 2022
…#10535) (vitessio#776) The canonical form of printing the vitess migration syntax would upcase the UUID value, but it needs to be passed through unchanged. This in turn led me to testing comments in a query as well and it turns out we wrongly change the case there as well. Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canonical form of printing the vitess migration syntax would upcase the UUID value, but it needs to be passed through unchanged.
This in turn led me to testing comments in a query as well and it turns out we wrongly change the case there as well.
Related Issue(s)
#10203
Checklist