Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing of vitess migration syntax and comments printing #10535

Conversation

dbussink
Copy link
Contributor

The canonical form of printing the vitess migration syntax would upcase the UUID value, but it needs to be passed through unchanged.

This in turn led me to testing comments in a query as well and it turns out we wrongly change the case there as well.

Related Issue(s)

#10203

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

The canonical form of printing the vitess migration syntax would upcase
the UUID value, but it needs to be passed through unchanged.

This in turn led me to testing comments in a query as well and it turns
out we wrongly change the case there as well.

Signed-off-by: Dirkjan Bussink <[email protected]>
@github-actions
Copy link
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@GuptaManan100 GuptaManan100 merged commit 4b9130f into vitessio:main Jun 17, 2022
@GuptaManan100 GuptaManan100 deleted the dbussink/fix-vitess-migration-and-comment-casing branch June 17, 2022 11:42
@frouioui frouioui mentioned this pull request Jun 22, 2022
43 tasks
GuptaManan100 pushed a commit to planetscale/vitess that referenced this pull request Jun 22, 2022
…#10535)

The canonical form of printing the vitess migration syntax would upcase
the UUID value, but it needs to be passed through unchanged.

This in turn led me to testing comments in a query as well and it turns
out we wrongly change the case there as well.

Signed-off-by: Dirkjan Bussink <[email protected]>
GuptaManan100 added a commit that referenced this pull request Jun 22, 2022
…10570)

The canonical form of printing the vitess migration syntax would upcase
the UUID value, but it needs to be passed through unchanged.

This in turn led me to testing comments in a query as well and it turns
out we wrongly change the case there as well.

Signed-off-by: Dirkjan Bussink <[email protected]>

Co-authored-by: Dirkjan Bussink <[email protected]>
rsajwani pushed a commit to planetscale/vitess that referenced this pull request Jun 27, 2022
…#10535) (vitessio#776)

The canonical form of printing the vitess migration syntax would upcase
the UUID value, but it needs to be passed through unchanged.

This in turn led me to testing comments in a query as well and it turns
out we wrongly change the case there as well.

Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants