-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport to release-14.0: Adds RPCs to vttablet that vtorc requires (#10464) #10546
Backport to release-14.0: Adds RPCs to vttablet that vtorc requires (#10464) #10546
Conversation
* feat: add vttablet rpc to reset replication parameters Signed-off-by: Manan Gupta <[email protected]> * feat: added end to end testing for the rpc and fixed bug Signed-off-by: Manan Gupta <[email protected]> * feat: fix typing error Signed-off-by: Manan Gupta <[email protected]> * feat: add basic full status rpc functionality and add test for it Signed-off-by: Manan Gupta <[email protected]> * feat: add all the fields needed in full status Signed-off-by: Manan Gupta <[email protected]> * test: moved the test to reparent tests and improved it Signed-off-by: Manan Gupta <[email protected]> * feat: bug fix for no replication status and no primary status Signed-off-by: Manan Gupta <[email protected]> * feat: add version to the full status output Signed-off-by: Manan Gupta <[email protected]> * feat: add binlog information to full status Signed-off-by: Manan Gupta <[email protected]> * docs: fix the comment explaining the binlog information Signed-off-by: Manan Gupta <[email protected]> * feat: add semi-sync statuses to full status Signed-off-by: Manan Gupta <[email protected]> * feat: call the correct command Signed-off-by: Manan Gupta <[email protected]> * feat: add server uuid and id to full status Signed-off-by: Manan Gupta <[email protected]> * feat: make server_id a uint32 to accept the correct range of values Signed-off-by: Manan Gupta <[email protected]> * feat: add few more fields to the full status like version comment, semi-sync settings, binlog_row_image Signed-off-by: Manan Gupta <[email protected]> * feat: generate vtadmin proto files Signed-off-by: Manan Gupta <[email protected]> * test: add assertion to check binlog row format is read correctly Signed-off-by: Manan Gupta <[email protected]> * feat: split GTID mode in its own function because mariadb doesn't support it Signed-off-by: Manan Gupta <[email protected]> * feat: fix parsing of empty mariadb gtid set Signed-off-by: Manan Gupta <[email protected]> * docs: add doucmentation for existing fields in ReplicationStatus Signed-off-by: Manan Gupta <[email protected]> * feat: add relay log file position to the replication status output Signed-off-by: Manan Gupta <[email protected]> * test: augmented full status test to check all the different positions stored Signed-off-by: Manan Gupta <[email protected]> * feat: add additional fields to replication status and read source user Signed-off-by: Manan Gupta <[email protected]> * feat: read sql delay from show replica status output Signed-off-by: Manan Gupta <[email protected]> * feat: read ssl allowed from show replica status output Signed-off-by: Manan Gupta <[email protected]> * feat: read has replication filters from show replica status output Signed-off-by: Manan Gupta <[email protected]> * feat: read auto position and using gtid from show replica status output Signed-off-by: Manan Gupta <[email protected]> * feat: add replication lag unknown too to replication status Signed-off-by: Manan Gupta <[email protected]> * feat: return nils from replication and primary postiion if it is not present Signed-off-by: Manan Gupta <[email protected]> * feat: rename FileRelayLogPosition in replication status output to RelayLogSourceBinLogEquivalentPosition and augment test to make sure rpc changes are backward compatible Signed-off-by: Manan Gupta <[email protected]> * feat: update vtadmin proto files Signed-off-by: Manan Gupta <[email protected]> * refactor: rename BinLog to binlog in renamed proto field Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
A bit late to be adding things to release-14.0, but we need this in order to allow people who are already using vtorc to upgrade from v14 to v15 without disruption. Technically vtorc in 14.0 is still experimental, but we wanted to go that extra mile for anyone who is already using it in production or planning to do so in v14. |
Signed-off-by: Manan Gupta <[email protected]>
Description
Backport of #10464
Related Issue(s)
Checklist
Deployment Notes