-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DDL: ALTER VIEW
to respect --postpone-completion
strategy flag
#11899
Online DDL: ALTER VIEW
to respect --postpone-completion
strategy flag
#11899
Conversation
…tement: test indicates a bug Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👀
go/vt/vttablet/onlineddl/executor.go
Outdated
// Any non-postponed migration can be scheduled | ||
// postponed ALTER can be scheduled | ||
// postponed ALTER ALTER can be scheduled (because gh-ost or vreplication will postpone the cut-over) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: ALTER is repeated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Signed-off-by: Shlomi Noach <[email protected]>
Replaced and superseded by #11910, which also handles INSTANT ddl as fast range partition rotation. |
Description
Addresses #11898, see bug description there.
This PR makes
ALTER VIEW
respect--postpone-completion
strategy flag, in a forward migration as well as in a revert migration.Added
endtoend
tests to validate.Related Issue(s)
#11898
Checklist