Online DDL CI: consolidated revertible and revert CI tests (part 1) #12183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
requested review from
GuptaManan100,
frouioui,
rohit-nayak-ps,
deepthi,
mattlord and
harshit-gangal
as code owners
vitess-bot
bot
added
NeedsDescriptionUpdate
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
mattlord
approved these changes
Jan 29, 2023
Comment on lines
351
to
352
| // func testOnlineDDLStatement(t *testing.T, alterStatement string, ddlStrategy string, executeStrategy string, expectHint string, expectError string, skipWait bool) (uuid string) { | ||
| // func testOnlineDDLStatement(t *testing.T, alterStatement string, ddlStrategy string, executeStrategy string, tableName string, expectHint string) (uuid string) { |
There was a problem hiding this comment.
We probably want to remove these?
There was a problem hiding this comment.
Whoops, thank you, fixed.
| DROP TABLE onlineddl_test | ||
| ` | ||
| tableName = "onlineddl_test" | ||
| ddlStrategy = "online -declarative -allow-zero-in-date" |
There was a problem hiding this comment.
I know this is internal, but IMO better for all of us to get into the habit of using double dashes everywhere.
There was a problem hiding this comment.
Agreed! Fixed.
Comment on lines
360
to
365
| t.Run("create from-table", func(t *testing.T) { | ||
| fromStatement := fmt.Sprintf(createTableWrapper, testcase.fromSchema) | ||
| uuid := testOnlineDDLStatement(t, fromStatement, ddlStrategy, "vtgate", tableName, "") | ||
| onlineddl.CheckMigrationStatus(t, &vtParams, shards, uuid, schema.OnlineDDLStatusComplete) | ||
| checkTable(t, tableName, true) | ||
| }) |
There was a problem hiding this comment.
It's not obvious to me how these are confirming it's revertible, but assuming it is (you would certainly know).
There was a problem hiding this comment.
Ah. This is just preparation. Per test case, we (re)create the table, then run a migration, then see if the migration is revertible. Added comments to clarify.
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
removed
NeedsDescriptionUpdate
3 tasks
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similarly to #12061 and #12055, we now consolidate
onlineddl_revertibleintoonlineddl_revert.After this has been merged, we can remove the
Requiredtag fromonlineddl_revertibleand then followup with a romval PR, much like #12182This will free two CI workflows.
Related Issue(s)
#6926
Checklist
Deployment Notes