Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-13.0] Bug fix: Cache filtered out tablets in topology watcher to avoid unnecessary GetTablet calls to topo #12242

Merged
merged 1 commit into from
Mar 3, 2023
Merged

[release-13.0] Bug fix: Cache filtered out tablets in topology watcher to avoid unnecessary GetTablet calls to topo #12242

merged 1 commit into from
Mar 3, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Feb 6, 2023

Description

This is a backport of #12194

@brirams @frouioui
Bug fix: Cache filtered out tablets in topology watcher to avoid unne…
e1885e7 
…cessary GetTablet calls to topo (vitessio#12194)

* check filter later in loadTablets. Add tests to confirm expected behavior

Signed-off-by: Brian Ramos <[email protected]>

* remove unnecessary assignment

Co-authored-by: Florent Poinsard <[email protected]>
Signed-off-by: Brian Ramos <[email protected]>

* add some explanation around TestFilterByKeypsaceSkipsIgnoredTablets

Signed-off-by: Brian Ramos <[email protected]>

* simplify filter check logic as well as major test cleanup, using testify where possible

Signed-off-by: Brian Ramos <[email protected]>

---------

Signed-off-by: Brian Ramos <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 6, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 6, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 6, 2023
mattlord
mattlord approved these changes Feb 7, 2023
View reviewed changes
go/vt/discovery/topology_watcher_test.go
// TestFilterByKeypsaceSkipsIgnoredTablets confirms a bug fix for the case when a TopologyWatcher
// has a FilterByKeyspace TabletFilter configured along with refreshKnownTablets turned off. We want
// to ensure that the TopologyWatcher:
// - does not continuosly call GetTablets for tablets that do not satisfy the filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I only noticed the continuosly typo now. :-) Oh well.

@frouioui frouioui merged commit 31f7bf7 into vitessio:release-13.0 Mar 3, 2023
@frouioui frouioui deleted the bp-12194-on-13 branch March 3, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@mattlord mattlord mattlord approved these changes

@brirams brirams Awaiting requested review from brirams

Assignees
No one assigned
Labels
Backport This is a backport Component: Cluster management Type: Bug Type: Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frouioui @deepthi @mattlord @brirams