Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental backup and point in time recovery for XtraBackup #13156

Merged
merged 32 commits into from
Jun 6, 2023
Merged

Incremental backup and point in time recovery for XtraBackup #13156

merged 32 commits into from
Jun 6, 2023

Commits on May 24, 2023

  1. incremental backup is always using 'builtin' engine 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 24, 2023
    Configuration menu
    Copy the full SHA
    6212772 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. restore: use 'builtin' for incremental restore 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 25, 2023
    Configuration menu
    Copy the full SHA
    bc9c029 View commit details
    Browse the repository at this point in the history

  2. test all backup types 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 25, 2023
    Configuration menu
    Copy the full SHA
    db506ca View commit details
    Browse the repository at this point in the history

  3. format code 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 25, 2023
    Configuration menu
    Copy the full SHA
    1ae6041 View commit details
    Browse the repository at this point in the history

  4. Populate PurgedPosition 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 25, 2023
    Configuration menu
    Copy the full SHA
    1b79d88 View commit details
    Browse the repository at this point in the history

  5. cleanup backups at the end of each test case 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 25, 2023
    Configuration menu
    Copy the full SHA
    b17db00 View commit details
    Browse the repository at this point in the history

  6. improved cleanup 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 25, 2023
    Configuration menu
    Copy the full SHA
    7f1a577 View commit details
    Browse the repository at this point in the history

  7. rename variable 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 25, 2023
    Configuration menu
    Copy the full SHA
    c40090f View commit details
    Browse the repository at this point in the history

  8. record all backups 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 25, 2023
    Configuration menu
    Copy the full SHA
    a042eb6 View commit details
    Browse the repository at this point in the history

  9. no need to cleanup backups in between test cases, since each new case… 

    … has a completely different UUID

Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 25, 2023
    Configuration menu
    Copy the full SHA
    33cb6cd View commit details
    Browse the repository at this point in the history

  10. install xtrabackup on backup_pitr tests 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 25, 2023
    Configuration menu
    Copy the full SHA
    7b7bd41 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2023

  1. use pgzip for xtrabackup 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 28, 2023
    Configuration menu
    Copy the full SHA
    a8e6817 View commit details
    Browse the repository at this point in the history

  2. more debug info 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 28, 2023
    Configuration menu
    Copy the full SHA
    a1af0fe View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. builtin engine: store gtid_purged in manifest 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 29, 2023
    Configuration menu
    Copy the full SHA
    6db1a8d View commit details
    Browse the repository at this point in the history

  2. use backupfrom-GTID as incremental-from-GTID if first binary log has … 

    …empty Previous-GTIDS

Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 29, 2023
    Configuration menu
    Copy the full SHA
    b5641cf View commit details
    Browse the repository at this point in the history

  3. more unit tests 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 29, 2023
    Configuration menu
    Copy the full SHA
    57877e6 View commit details
    Browse the repository at this point in the history

  4. improve error message 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 29, 2023
    Configuration menu
    Copy the full SHA
    9b9016d View commit details
    Browse the repository at this point in the history

  5. capturing MySQL's stderr and reading and logging if not empty 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 29, 2023
    Configuration menu
    Copy the full SHA
    a2dc603 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. At the end of Xtrabackup restore, validate that @@gtid_purged (and th… 

    …ereby @@gtid_executed) are set to the backup's @@gtid_purge. Make it so if they aren't

Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 30, 2023
    Configuration menu
    Copy the full SHA
    fa66d2c View commit details
    Browse the repository at this point in the history

  2. add comperssion details into test case. Fix GTID validation of manife… 

    …st file

Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 30, 2023
    Configuration menu
    Copy the full SHA
    136126b View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. check manifest 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c28a9ab View commit details
    Browse the repository at this point in the history

  2. Refactor into function 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f40db18 View commit details
    Browse the repository at this point in the history

  3. check manifest.Position.GTIDSet 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 31, 2023
    Configuration menu
    Copy the full SHA
    741cfeb View commit details
    Browse the repository at this point in the history

  4. fix wrangler tests 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5fbe3d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. typo 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    abf6672 View commit details
    Browse the repository at this point in the history

  2. Update go/vt/mysqlctl/backup.go 

    Co-authored-by: Matt Lord <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach @mattlord
    shlomi-noach and mattlord authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    4f5fd46 View commit details
    Browse the repository at this point in the history

  3. Update go/vt/mysqlctl/backup.go 

    Co-authored-by: Matt Lord <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach @mattlord
    shlomi-noach and mattlord authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    289645e View commit details
    Browse the repository at this point in the history

  4. Update go/vt/mysqlctl/backup.go 

    Co-authored-by: Matt Lord <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach @mattlord
    shlomi-noach and mattlord authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    027f33d View commit details
    Browse the repository at this point in the history

  5. typo 

    Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach
    shlomi-noach committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    2b02ab7 View commit details
    Browse the repository at this point in the history

  6. Update go/vt/mysqlctl/mysqld.go 

    Co-authored-by: Matt Lord <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach @mattlord
    shlomi-noach and mattlord authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    fe2aa08 View commit details
    Browse the repository at this point in the history

  7. Update go/vt/mysqlctl/mysqld.go 

    Co-authored-by: Matt Lord <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach @mattlord
    shlomi-noach and mattlord authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    63890aa View commit details
    Browse the repository at this point in the history

  8. Update go/vt/mysqlctl/mysqld.go 

    Co-authored-by: Matt Lord <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
    @shlomi-noach @mattlord
    shlomi-noach and mattlord authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a67e497 View commit details
    Browse the repository at this point in the history