Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakiness in TestDeadPrimaryRecoversImmediately #13232

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Fix flakiness in TestDeadPrimaryRecoversImmediately #13232

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1821bc9
feat: fix flakiness in TestDeadPrimaryRecoversImmediately
GuptaManan100 Jun 5, 2023
b09c4c0
feat: fix comment
GuptaManan100 Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion go/test/endtoend/vtorc/primaryfailure/primary_failure_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,10 @@ func TestDownPrimary(t *testing.T) {
// that primary is unreachable. This help us save few seconds depending on value of `RemoteOperationTimeout` flag.
func TestDeadPrimaryRecoversImmediately(t *testing.T) {
defer cluster.PanicHandler(t)
utils.SetupVttabletsAndVTOrcs(t, clusterInfo, 2, 1, []string{"--remote_operation_timeout=10s"}, cluster.VTOrcConfiguration{
// We specify the wait replica's timeout to a small value because we spawn a cross-cell replica later in the test.
GuptaManan100 marked this conversation as resolved.
Show resolved Hide resolved
// If that replica is more advanced the same-cell-replica, then we would try to promote the cross-cell replica as an intermediate source.
GuptaManan100 marked this conversation as resolved.
Show resolved Hide resolved
// If we don't specify a small value of wait-replicas-timeout, then we would end up waiting for 30 seconds for the dead-primary to respond, failing this test.
utils.SetupVttabletsAndVTOrcs(t, clusterInfo, 2, 1, []string{"--remote_operation_timeout=10s", "--wait-replicas-timeout=5s"}, cluster.VTOrcConfiguration{
PreventCrossDataCenterPrimaryFailover: true,
}, 1, "semi_sync")
keyspace := &clusterInfo.ClusterInstance.Keyspaces[0]
Expand Down