Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: use *time.Ticker instead of time.After() #13492

Merged
merged 2 commits into from
Jul 20, 2023
Merged

stats: use *time.Ticker instead of time.After() #13492

merged 2 commits into from
Jul 20, 2023

Commits on Jul 14, 2023

  1. stats: use *time.Ticker instead of time.After() 

    Seems like the intention is was to snapshot() on an interval, time.After()
does work, but it allocates a *Timer on every tick while *time.Ticker uses
the same channel.

Signed-off-by: Amir Abushareb <[email protected]>
    @yields
    yields committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    7e649f8 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Merge remote-tracking branch 'upstream/main' into a/ticker 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    3785073 View commit details
    Browse the repository at this point in the history