-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtgate table schema tracking to use GetSchema rpc #13544
Changes from all commits
9ce0ecd
4a18c38
d909515
3dcaa20
1099c06
39c6684
7fd0bae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,15 +26,12 @@ import ( | |
"time" | ||
|
||
"github.com/stretchr/testify/assert" | ||
|
||
"vitess.io/vitess/go/test/endtoend/utils" | ||
"vitess.io/vitess/go/vt/sidecardb" | ||
"vitess.io/vitess/go/vt/vtgate/planbuilder" | ||
|
||
"github.com/stretchr/testify/require" | ||
|
||
"vitess.io/vitess/go/mysql" | ||
"vitess.io/vitess/go/test/endtoend/cluster" | ||
"vitess.io/vitess/go/test/endtoend/utils" | ||
"vitess.io/vitess/go/vt/sidecardb" | ||
) | ||
|
||
var ( | ||
|
@@ -86,15 +83,10 @@ func TestMain(m *testing.M) { | |
VSchema: VSchema, | ||
SidecarDBName: sidecarDBName, | ||
} | ||
clusterInstance.VtGateExtraArgs = []string{"--schema_change_signal", | ||
"--vschema_ddl_authorized_users", "%", | ||
"--schema_change_signal_user", "userData1"} | ||
clusterInstance.VtGatePlannerVersion = planbuilder.Gen4 | ||
clusterInstance.VtTabletExtraArgs = []string{"--queryserver-config-schema-change-signal", | ||
"--queryserver-config-schema-change-signal-interval", "0.1", | ||
"--queryserver-config-strict-table-acl", | ||
"--queryserver-config-acl-exempt-acl", "userData1", | ||
"--table-acl-config", "dummy.json"} | ||
clusterInstance.VtGateExtraArgs = append(clusterInstance.VtGateExtraArgs, | ||
"--schema_change_signal", | ||
"--vschema_ddl_authorized_users", "%") | ||
clusterInstance.VtTabletExtraArgs = append(clusterInstance.VtTabletExtraArgs, "--queryserver-config-schema-change-signal") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some acl flags have also been dropped. Is that intentional? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is not required anymore. I will add a deprecation note for it. |
||
|
||
if vtgateVer >= 16 && vttabletVer >= 16 { | ||
clusterInstance.VtGateExtraArgs = append(clusterInstance.VtGateExtraArgs, "--enable-views") | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -145,8 +145,8 @@ func TestMain(m *testing.M) { | |
sidecarDBName = sidecardb.DefaultName | ||
} | ||
|
||
clusterInstance.VtGateExtraArgs = []string{"--schema_change_signal", "--schema_change_signal_user", "userData1"} | ||
clusterInstance.VtTabletExtraArgs = []string{"--queryserver-config-schema-change-signal", "--queryserver-config-schema-change-signal-interval", "5", "--queryserver-config-strict-table-acl", "--queryserver-config-acl-exempt-acl", "userData1", "--table-acl-config", "dummy.json"} | ||
clusterInstance.VtGateExtraArgs = append(clusterInstance.VtGateExtraArgs, "--schema_change_signal") | ||
clusterInstance.VtTabletExtraArgs = append(clusterInstance.VtTabletExtraArgs, "--queryserver-config-schema-change-signal") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same acl question There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
// Start topo server | ||
err = clusterInstance.StartTopo() | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are no longer using the signal interval is that expected? If yes, we should remove the definition of
signalInterval
on line45
.