Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for "text type with an unknown/unsupported collation cannot be hashed" error #13852

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fix for "text type with an unknown/unsupported collation cannot be hashed" error #13852

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b56c69
feat: figure out the type of weightstrings added late
systay Aug 25, 2023
7e40417
check the map first
systay Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions go/test/endtoend/preparestmt/stmt_methods_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,3 +436,24 @@ func TestShowColumns(t *testing.T) {
require.Len(t, cols, 6)
require.False(t, rows.Next())
}

func TestBinaryColumn(t *testing.T) {
defer cluster.PanicHandler(t)
dbo := Connect(t, "interpolateParams=false")
defer dbo.Close()

_, err := dbo.Query(`SELECT DISTINCT
BINARY table_info.table_name AS table_name,
table_info.create_options AS create_options,
table_info.table_comment AS table_comment
FROM information_schema.tables AS table_info
JOIN information_schema.columns AS column_info
ON BINARY column_info.table_name = BINARY table_info.table_name
WHERE
table_info.table_schema = ?
AND column_info.table_schema = ?
-- Exclude views.
AND table_info.table_type = 'BASE TABLE'
ORDER BY BINARY table_info.table_name`, keyspaceName, keyspaceName)
require.NoError(t, err)
}
8 changes: 8 additions & 0 deletions go/vt/vtgate/semantics/semantic_state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,14 @@ func (st *SemTable) AddExprs(tbl *sqlparser.AliasedTableExpr, cols sqlparser.Sel

// TypeForExpr returns the type of expressions in the query
func (st *SemTable) TypeForExpr(e sqlparser.Expr) (sqltypes.Type, collations.ID, bool) {
// We add a lot of WeightString() expressions to queries at late stages of the planning,
// which means that they don't have any type information. We can safely assume that they
// are VarBinary, since that's the only type that WeightString() can return.
_, isWS := e.(*sqlparser.WeightStringFuncExpr)
if isWS {
return sqltypes.VarBinary, collations.CollationBinaryID, true
}

if typ, found := st.ExprTypes[e]; found {
return typ.Type, typ.Collation, true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rearrange this check and do this first

if typ, found := st.ExprTypes[e]; found {
    return typ.Type, typ.Collation, true
}

if not found then check the expression for the weight_string function

Expand Down
Loading