-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] migrate query analyzer to cobra #13945
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
0fcfcf1
to
7c98786
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering whether this binary is still relevant, and whether we should delete it instead of migrating it. @vitessio/query-serving WDYT?
Though you've already done the migration work, of course :(
I'm good with that if query-serving doesn't want this around anymore!
No prob, it's no trouble either way! |
I have opened #14054, I think it is okay to remove this binary altogether. Closing this PR for now. |
Description
Huzzah for self-descriptive PR titles
Related Issue(s)
#13918
Checklist
Deployment Notes