Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] migrate query analyzer to cobra #13945

Closed
wants to merge 2 commits into from

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Sep 10, 2023

Description

Huzzah for self-descriptive PR titles

Related Issue(s)

#13918

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required: document query_analyzer website#1581

Deployment Notes

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 10, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 10, 2023
@github-actions github-actions bot added this to the v18.0.0 milestone Sep 10, 2023
Andrew Mason added 2 commits September 10, 2023 09:58
@deepthi deepthi removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Sep 11, 2023
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether this binary is still relevant, and whether we should delete it instead of migrating it. @vitessio/query-serving WDYT?
Though you've already done the migration work, of course :(

@ajm188
Copy link
Contributor Author

ajm188 commented Sep 11, 2023

I'm wondering whether this binary is still relevant, and whether we should delete it instead of migrating it. @vitessio/query-serving WDYT?

I'm good with that if query-serving doesn't want this around anymore!

Though you've already done the migration work, of course :(

No prob, it's no trouble either way!

@frouioui
Copy link
Member

frouioui commented Sep 20, 2023

I have opened #14054, I think it is okay to remove this binary altogether. Closing this PR for now.

@frouioui frouioui closed this Sep 20, 2023
@frouioui frouioui deleted the andrew/cobra-query-analyzer branch September 20, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants