Add check in healthcheck to detect timeout. #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,7 +38,8 @@ import ( | |||
| var ( | |||
| healthcheckTopologyRefresh = flag.Duration("binlog_player_healthcheck_topology_refresh", 30*time.Second, "refresh interval for re-reading the topology when filtered replication is running") | |||
|
|
|||
| retryDelay = flag.Duration("binlog_player_retry_delay", 5*time.Second, "delay before retrying a failed healthcheck or a failed binlog connection") | |||
| retryDelay = flag.Duration("binlog_player_retry_delay", 5*time.Second, "delay before retrying a failed healthcheck or a failed binlog connection") | |||
| healthCheckTimeout = flag.Duration("healthcheck_timeout", time.Minute, "the health check timeout period") | |||
There was a problem hiding this comment.
We should prefix this one with binlog_player_ as we may get more later.
|
@alainjobart Can you take a look? |
|
You can just submit this without calling Close() in binlog.go, and I'll do it. The life cycles of the healthchecks guys need to be fixed, I'll do that. In the meantime, having the resource leak is OK, I'll take a look on Monday. So LGTM |
guoliang100
added a commit
that referenced
this pull request
Dec 19, 2015
Add check in healthcheck to detect timeout.
dbussink
added a commit
that referenced
this pull request
Jan 30, 2023
) * feat: fix checkMySQL and add tests and documentation (#11895) (#1391) Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> * more unit tests for QueryMatchesTemplates() (#11894) (#1394) Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> * Simplify `getPlan` and `gen4CompareV3` (#11903) (#1400) * simplify getPlan and gen4CompareV3 Signed-off-by: Florent Poinsard <[email protected]> * fix error return in getPlan Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> * Fix merge issue found during make Signed-off-by: Rohit Nayak <[email protected]> * Disable MIN() / MAX() support (#1399) It's trivially simple today to trigger a panic for these, because the invalidation steps are not there and they panic. So if you remove a value that's the maximum or minimum, we panic and crash. Better to block creating this for now and fix the underlying problem first and then allow it again. Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]> * Always use public id internally for mappings (#1398) * Always use public id internally for mappings We were using the `.Name` attribute of a query in a few places internally as a hash key, but that is broken. There's no guarantee that we always have a name, let alone that it's guaranteed to be unique. This switches to using the public id and adds additional validation checks that it's always set and that it's always unique for hash map lookups. The case where this was blowing up is that end-to-end tests would fail if there's no name for a query and no name through a special comment either. We also likely would have seen very strange bugs if someone named their query "source" since that's a special node name and we used the name as node names as well. Signed-off-by: Dirkjan Bussink <[email protected]> * integration: use default view ids Signed-off-by: Vicent Marti <[email protected]> * boost: do not use Public IDs as names Signed-off-by: Vicent Marti <[email protected]> * boost: do not use node IDs for table names either Signed-off-by: Vicent Marti <[email protected]> * boost: fix test issues Signed-off-by: Vicent Marti <[email protected]> * boost: fix protogen Signed-off-by: Vicent Marti <[email protected]> * incorporator: do not panic Signed-off-by: Vicent Marti <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Vicent Marti <[email protected]> Co-authored-by: Vicent Marti <[email protected]> * feat: add test and fix the error of not sending a ServerLost error on server side error (#11920) (#1405) Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> * Onlineddl: formalize "immediate operations", respect `--postpone-completion` strategy flag (#11910) (#1411) * Added endtoend test to validate postponed REVERT of an ALTER VIEW statement: test indicates a bug Signed-off-by: Shlomi Noach <[email protected]> * ALTER VIEW now respects --postpone-completion flag Signed-off-by: Shlomi Noach <[email protected]> * Online DDL: formalize 'immediate operations', respect --postpone-completion Signed-off-by: Shlomi Noach <[email protected]> * typo Signed-off-by: Shlomi Noach <[email protected]> * only test instant ddl in capable versions (ie 8.0) Signed-off-by: Shlomi Noach <[email protected]> * more specific instant ddl capability Signed-off-by: Shlomi Noach <[email protected]> * Update go/vt/vttablet/onlineddl/executor.go Co-authored-by: Deepthi Sigireddi <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> * Update go/vt/vttablet/onlineddl/executor.go Co-authored-by: Deepthi Sigireddi <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> * Update go/vt/vttablet/onlineddl/executor.go Co-authored-by: Deepthi Sigireddi <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: Deepthi Sigireddi <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> Co-authored-by: Deepthi Sigireddi <[email protected]> * log: also log error in DiscoverInstance when force discovery is specified (#11936) (#1410) Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Vicent Marti <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: Shlomi Noach <[email protected]> Co-authored-by: FlorentP <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]> Co-authored-by: Vicent Marti <[email protected]> Co-authored-by: Deepthi Sigireddi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alainjobart @sougou