Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CreateLookupVindex and ExternalizeVindex to vtctldclient #14086

Merged
merged 26 commits into from
Oct 4, 2023
Merged

Migrate CreateLookupVindex and ExternalizeVindex to vtctldclient #14086

merged 26 commits into from
Oct 4, 2023

Commits on Sep 25, 2023

  1. Add LookupVindex command 

    This covers the legacy CreateLookupVindex and
ExternalizeVindex commands.

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    073b771 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Migrate unit tests 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    08034be View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Merge remote-tracking branch 'origin/main' into vtctldclient_lookupvi… 

    …ndex

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    4eecbaa View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2023

  1. Finish unit tests 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    69bc219 View commit details
    Browse the repository at this point in the history

  2. Fixup unit test 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    c60da24 View commit details
    Browse the repository at this point in the history

  3. Corrections 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    0dfb0d9 View commit details
    Browse the repository at this point in the history

  4. Ajust variable name to match flag 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    5b8baa0 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Rework/correct how we handle the keyspaces involved 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    99547cb View commit details
    Browse the repository at this point in the history

  2. Minor changes after self review 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    e91b9f0 View commit details
    Browse the repository at this point in the history

  3. Fixup unit test after changes 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    7bf2d5e View commit details
    Browse the repository at this point in the history

  4. Add support for specifying the target table's primary vindex 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    31a2117 View commit details
    Browse the repository at this point in the history

  5. Remove redundant Long cmd value. 

    The available commands are already shown in the help output
so these added no practical value while introducing text
that could drift from the implementation.

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    f809f86 View commit details
    Browse the repository at this point in the history

  6. Minor changes after self review 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    8f11f68 View commit details
    Browse the repository at this point in the history

  7. Typo in comment 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    aff651f View commit details
    Browse the repository at this point in the history

  8. Rename shared function appropriately 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    0e259ce View commit details
    Browse the repository at this point in the history

  9. Revert "Rename shared function appropriately" 

    This reverts commit 0e259ce.

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    e1a622e View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Fix typo and use consistent case for Lookup Vindex 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    3eec1c3 View commit details
    Browse the repository at this point in the history

  2. Minor final changes 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    b2b1afd View commit details
    Browse the repository at this point in the history

  3. Change default of continue-after-copy-with-owner to true 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    d1680cd View commit details
    Browse the repository at this point in the history

  4. Add specs and specs-file flags 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    e90cbc4 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Refactor to use flags 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    ffb1ab1 View commit details
    Browse the repository at this point in the history

  2. Update unit tests 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    bcb37fd View commit details
    Browse the repository at this point in the history

  3. Changes after self review and local testing 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    049b779 View commit details
    Browse the repository at this point in the history

  4. Fix the e2e test 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    82eac4a View commit details
    Browse the repository at this point in the history

  5. Fix unit tests. Improve errors 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    102e188 View commit details
    Browse the repository at this point in the history

  6. Minor changes after final self review 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    e0943a2 View commit details
    Browse the repository at this point in the history