set vreplication net read and net write timeout session vars to high values #14203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…values Signed-off-by: Olga Shestopalova <[email protected]>
olyazavr
requested review from
harshit-gangal,
systay,
shlomi-noach,
rohit-nayak-ps and
mattlord
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
Signed-off-by: Olga Shestopalova <[email protected]>
rohit-nayak-ps
added
Type: Enhancement
rohit-nayak-ps
requested changes
Oct 10, 2023
| @@ -60,6 +60,8 @@ const ( | |||
| getAutoIncrementStep = "select @@session.auto_increment_increment" | |||
| setSessionTZ = "set @@session.time_zone = '+00:00'" | |||
| setNames = "set names 'binary'" | |||
| setNetReadTimeout = "set @@session.net_read_timeout = 300" | |||
There was a problem hiding this comment.
We were discussing this yesterday and the consensus was that we should not hardcode values since the actual value might vary based on the cluster environment.
We can add flags for this as common vttablet flags similar to the query timeout PR. Your values seem fine as defaults to me.
added 3 commits
October 10, 2023 15:11
Signed-off-by: Olga Shestopalova <[email protected]>
Signed-off-by: Olga Shestopalova <[email protected]>
Signed-off-by: Olga Shestopalova <[email protected]>
dbussink
approved these changes
Oct 11, 2023
4 tasks
pjambet
pushed a commit
to Shopify/vitess
that referenced
this pull request
Nov 8, 2023
…values (vitessio#14203) Signed-off-by: Olga Shestopalova <[email protected]> Co-authored-by: Olga Shestopalova <[email protected]>
pawandubey
pushed a commit
to Shopify/vitess
that referenced
this pull request
Apr 5, 2024
…values (vitessio#14203) Signed-off-by: Olga Shestopalova <[email protected]> Co-authored-by: Olga Shestopalova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On some particularly busy tables, we cannot run vitess onlineddl schema changes because it fails with
unexpected EOF\nio.ReadFull(packet body of length 287) failed (errno 2013) (sqlstate HY000). Note that ghost also fails on these tables, but we have higher hopes for vitess.In several slack threads, the recommendation was to increase
net_read_timeout(default is 30, recommended for vreplication is 300) andnet_write_timeout(default is 60, recommended for vreplication is 600). However, we don't want to modify these values globally, would be nice if only vreplication's session had these higher values - and this PR does just thatUpdate: with these changes, we were able to successfully run onlineddl schema changes on an incredibly busy table that was previously unable to run any kind of migrations
Related Issue(s)
Fixes #14202
Checklist
Deployment Notes