Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreign key on update action with non literal values #14278

Merged
merged 47 commits into from
Nov 10, 2023
Merged

Foreign key on update action with non literal values #14278

merged 47 commits into from
Nov 10, 2023

Commits on Oct 17, 2023

  1. store child foreign key to update exprs mapping 

    Signed-off-by: Harshit Gangal <[email protected]>
    @harshit-gangal @GuptaManan100
    harshit-gangal authored and GuptaManan100 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    5002c3a View commit details
    Browse the repository at this point in the history

  2. refactor: add only unique columns to select expressions 

    Signed-off-by: Harshit Gangal <[email protected]>
    @harshit-gangal @GuptaManan100
    harshit-gangal authored and GuptaManan100 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    929b7b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Merge remote-tracking branch 'upstream/main' into fk-updstmt 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    3bcf8ae View commit details
    Browse the repository at this point in the history

  2. test: improve the fuzzer test to generate expressions containing colu… 

    …mns and literals for update queries

Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    fab5e3f View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. feat: add basic planning and execution support for update non-literal… 

    … queries

Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    f7734cd View commit details
    Browse the repository at this point in the history

  2. test: update tests and only print values if they aren't empty 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    c0c9ae6 View commit details
    Browse the repository at this point in the history

  3. feat: handle nils in comperator expression 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    ca13490 View commit details
    Browse the repository at this point in the history

  4. test: add a failing test 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    a68c8d6 View commit details
    Browse the repository at this point in the history

  5. feat: copy the order by from the update query 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    27a78be View commit details
    Browse the repository at this point in the history

  6. feat: turn off foreign key checks on updates that have foreign key co… 

    …lumns being set to non-literal values

Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    9b191a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Merge remote-tracking branch 'upstream/main' into fk-updstmt 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    17c8d90 View commit details
    Browse the repository at this point in the history

  2. test: refactor tests and permanently add cases for updates with non-l… 

    …iteral expressions

Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8470476 View commit details
    Browse the repository at this point in the history

  3. test: udpate tests output 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    b1432c4 View commit details
    Browse the repository at this point in the history

  4. feat: add AND rewriter to drop some unnecessary predicates 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    fd79f83 View commit details
    Browse the repository at this point in the history

  5. feat: add non-literal update parent foreign key verification 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    465df5d View commit details
    Browse the repository at this point in the history

  6. feat: augment verification queries to work with non-literal values in… 

    … updates

Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    a1b04e4 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. some refactor to club update related offsets 

    Signed-off-by: Harshit Gangal <[email protected]>
    @harshit-gangal
    harshit-gangal committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    4401200 View commit details
    Browse the repository at this point in the history

  2. reject queries with fk column update dependent column also getting up… 

    …dated

Signed-off-by: Harshit Gangal <[email protected]>
    @harshit-gangal
    harshit-gangal committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    adfd62f View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. fuzz: fix fuzzer to only produce queries that work with Vitess and My… 

    …sql for single threaded mode

Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    2a04ecf View commit details
    Browse the repository at this point in the history

  2. feat: fix update planning to produce correct not in tuple comparison 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    474a337 View commit details
    Browse the repository at this point in the history

  3. feat: fix fk_cascade engine to handle null comparisons correctly 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    1ec7b00 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. feat: refactor and fix update expressions dependency logic 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    5f9ad38 View commit details
    Browse the repository at this point in the history

  2. feat: fix literal updates clubbed with non-literal updates 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    64bbabd View commit details
    Browse the repository at this point in the history

  3. feat: refactor code so that checking for non-literal updates is now a… 

    … function which we only run when required

Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    c2a3ff2 View commit details
    Browse the repository at this point in the history

  4. feat: remove unused code 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f3c4d7f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. test: fix the timeout for waiting for replication 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    b14dc7b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into fk-updstmt 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    139f4f5 View commit details
    Browse the repository at this point in the history

  3. test: add fuzzer test for olap queries too 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    b777870 View commit details
    Browse the repository at this point in the history

  4. feat: add support for non-literal update in streaming 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    14caa24 View commit details
    Browse the repository at this point in the history

  5. feat: fix fkVerify to rollback transaction when select returns rows 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    47ee14d View commit details
    Browse the repository at this point in the history

  6. test: update test output post merge 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c40e9c4 View commit details
    Browse the repository at this point in the history

  7. feat: fix serializing of foreign keys 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6e152df View commit details
    Browse the repository at this point in the history

  8. refactor: make childFkToUpdExprs map unexported 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    16ff17c View commit details
    Browse the repository at this point in the history

  9. refactor: minor refactors and adding comments 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    252f859 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. test: add tests for fk_cascade engine changes 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    e1abd98 View commit details
    Browse the repository at this point in the history

  2. test: add tests for the function checking for foreign key columns bei… 

    …ng dependent on updated columns

Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a758a78 View commit details
    Browse the repository at this point in the history

  3. test: add tests for the function checking for non-literal fk updates 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    fcf6eba View commit details
    Browse the repository at this point in the history

  4. test: add tests for check fk updated expresssions map 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    fa8370c View commit details
    Browse the repository at this point in the history

  5. comments: fix typing errors 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8dc17e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Merge remote-tracking branch 'upstream/main' into fk-updstmt 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    81c395c View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. feat: change non-literal comparison added in updates to use null safe… 

    … equality check

Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a74c0aa View commit details
    Browse the repository at this point in the history

  2. feat: change the error to also contain the column names that are caus… 

    …ing the query to fail

Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    b3e1f6e View commit details
    Browse the repository at this point in the history

  3. feat: refactor code to keep all the non-literal update information to… 

    …gether in a struct

Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    2ffd0dd View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. feat: remove stream execute from fk_cascade and fk_verify. Instead ju… 

    …st use TryExecute instead

Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    0736eff View commit details
    Browse the repository at this point in the history

  2. refactor: simplify code 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    f5ae666 View commit details
    Browse the repository at this point in the history

  3. refactor: fix comment and refactor code 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    4969e50 View commit details
    Browse the repository at this point in the history

  4. feat: refactor code and tests to address review comments 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d319cd6 View commit details
    Browse the repository at this point in the history