Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

servenv: Remove double close() logic #14457

Merged
merged 2 commits into from
Nov 4, 2023
Merged

servenv: Remove double close() logic #14457

merged 2 commits into from
Nov 4, 2023

Commits on Nov 3, 2023

  1. servenv: Remove double close() logic 

    The servenv.Run function already runs the close hooks once it finishes.
This means there's no use for deferring a `.Close()` since it double
executes all close hooks.

In fact, it leads to panics. For example, vttablet always panics on each
shutdown because the connection to the topo is already closed.

Signed-off-by: Dirkjan Bussink <[email protected]>
    @dbussink
    dbussink committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    f8d7f32 View commit details
    Browse the repository at this point in the history

  2. servenv: reset ListeningURL when closing 

    Signed-off-by: deepthi <[email protected]>
    @deepthi
    deepthi committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b731d5e View commit details
    Browse the repository at this point in the history