Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MySQL apt package and GPG signature #14785

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Update MySQL apt package and GPG signature #14785

merged 5 commits into from
Dec 15, 2023

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Dec 14, 2023 •
edited
Loading

Description

The 3A79BD29 key expires on 2023-12-14. A new replacement key (A8D3785C) will sign upcoming MySQL 8.0.36 and higher packages. Both keys are installed by the MySQL repository setup packages released with MySQL 8.0.35, and both keys are also available at https://repo.mysql.com/.

See:

Note: this is currently blocked by https://bugs.mysql.com/bug.php?id=113427

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 14, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 14, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Dec 14, 2023
@mattlord mattlord added Type: Internal Cleanup Component: Build/CI Type: CI/Build Backport to: release-16.0 Backport to: release-18.0 Needs to be back ported to release-18.0 and removed Type: Internal Cleanup NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work labels Dec 14, 2023
@deepthi deepthi removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Dec 14, 2023
@deepthi deepthi marked this pull request as ready for review December 14, 2023 23:10
@deepthi
Copy link
Member

deepthi commented Dec 14, 2023

Once the blocking issue is resolved, this should be reviewed and merged ASAP.

@mattlord mattlord merged commit c2ff09f into vitessio:main Dec 15, 2023
116 checks passed
@mattlord mattlord deleted the mysql_ci_pkg_updates branch December 15, 2023 14:51
This was referenced Dec 15, 2023
Merged
Merged
Merged
mattlord added a commit that referenced this pull request Dec 15, 2023
@mattlord
Update MySQL apt package and GPG signature (#14785)
b8d58d3 
Signed-off-by: Matt Lord <[email protected]>
mattlord added a commit that referenced this pull request Dec 15, 2023
@mattlord
Update MySQL apt package and GPG signature (#14785)
6a46bc7 
Signed-off-by: Matt Lord <[email protected]>
mattlord added a commit that referenced this pull request Dec 15, 2023
@mattlord
Update MySQL apt package and GPG signature (#14785)
1f9cddf 
Signed-off-by: Matt Lord <[email protected]>
mattlord added a commit that referenced this pull request Dec 15, 2023
@vitess-bot @mattlord
[release-18.0] Update MySQL apt package and GPG signature (#14785) (#…
3d75c2c 
…14792)

Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: Matt Lord <[email protected]>
mattlord added a commit that referenced this pull request Dec 15, 2023
@vitess-bot @mattlord
[release-16.0] Update MySQL apt package and GPG signature (#14785) (#…
0b7dd2a 
…14790)

Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: Matt Lord <[email protected]>
mattlord added a commit that referenced this pull request Dec 15, 2023
@vitess-bot @mattlord
[release-17.0] Update MySQL apt package and GPG signature (#14785) (#…
3f4a588 
…14791)

Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: Matt Lord <[email protected]>
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Jan 24, 2024
@mattlord @ejortegau
Update MySQL apt package and GPG signature (vitessio#14785)
8a68f61 
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Eduardo J. Ortega U. <[email protected]>
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request Feb 28, 2024
@mattlord @timvaillancourt
Update MySQL apt package and GPG signature (vitessio#14785)
24da72f 
Signed-off-by: Matt Lord <[email protected]>
@timvaillancourt timvaillancourt mentioned this pull request Feb 28, 2024
Merged
4 tasks
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request Mar 12, 2024
@mattlord @timvaillancourt
Update MySQL apt package and GPG signature (vitessio#14785)
9040f14 
Signed-off-by: Matt Lord <[email protected]>
@timvaillancourt timvaillancourt mentioned this pull request Mar 12, 2024
Merged
4 tasks
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Mar 14, 2024
@timvaillancourt @mattlord
slack-vitess-r15.0.5: update CODEOWNERS (#250)
687889c 
* `slack-vitess-r15.0.5`: update `CODEOWNERS` and go runtime

Signed-off-by: Tim Vaillancourt <[email protected]>

* Update MySQL apt package and GPG signature (vitessio#14785)

Signed-off-by: Matt Lord <[email protected]>

* gofmt complaint

Signed-off-by: Tim Vaillancourt <[email protected]>

* make sizegen

Signed-off-by: Tim Vaillancourt <[email protected]>

* Update docker/bootstrap/Dockerfile.common

Signed-off-by: Tim Vaillancourt <[email protected]>

* Use go1.20.14

Signed-off-by: Tim Vaillancourt <[email protected]>

* make sizegen

Signed-off-by: Tim Vaillancourt <[email protected]>

* Revert to go1.18

Signed-off-by: Tim Vaillancourt <[email protected]>

* make proto again

Signed-off-by: Tim Vaillancourt <[email protected]>

---------

Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: Matt Lord <[email protected]>
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Mar 15, 2024
@timvaillancourt @mattlord
slack-vitess-r15.0.5: backport v20 vtgate syscall/topo-call optim…
355006a 
…izations (#227)

* Load `--grpc_auth_static_client_creds` file once (vitessio#15030)

Signed-off-by: Tim Vaillancourt <[email protected]>

* Filter by keyspace earlier in `tabletgateway`s `WaitForTablets(...)` (vitessio#15347)

Signed-off-by: Tim Vaillancourt <[email protected]>

* Limit concurrent creation of healthcheck gRPC connections (vitessio#15053)

Signed-off-by: Tim Vaillancourt <[email protected]>

* go mod tidy

Signed-off-by: Tim Vaillancourt <[email protected]>

* Update MySQL apt package and GPG signature (vitessio#14785)

Signed-off-by: Matt Lord <[email protected]>

* remove unrelated workflow files from v20

Signed-off-by: Tim Vaillancourt <[email protected]>

---------

Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: Matt Lord <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbussink dbussink dbussink approved these changes

@systay systay systay approved these changes

@ajm188 ajm188 ajm188 approved these changes

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
Backport to: release-18.0 Needs to be back ported to release-18.0 Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mattlord @deepthi @dbussink @systay @ajm188 @rohit-nayak-ps