Do not load table stats when booting vttablet.

[arthurschreiber]

Description

As part of the bootup process, vttablet reloads the schema engine, with table statistics information like table size, via the BaseShowTablesWithSizes query. This query is relatively expensive, but calling it once on vttablet bootup doesn't really seem much like an issue in production environments.

But in vtcombo, where a lot of vttablet instances are booted up on startup, all these BaseShowTablesWithSizes calls can add up, especially when there's a lot of tables / tablespaces.

In our CI system, where we use vtcombo, just the process of starting vtcombo on MySQL 8.0 takes 70 (!) seconds. On MySQL 5.7, it takes 26 seconds.

I already prepared a PR to halve the cost of running BaseShowTablesWithSizes on MySQL 8.0. But you know what's even better than halving the cost of this query? Not even running it in the first place!

This pull request proposes to skip the table size collection when booting up vttablet. This will improve the startup time, with virtually no negative side effect. The table statistics will be collected during the next regular schema engine reload interval.

This brings vtcombo bootup time in our CI system down to roughly 15 seconds, both on MySQL 5.7 and MySQL 8.0.

I'd really love to see this backported, because it's a massive performance improvement for everyone using vtcombo without any noticeable negative side effects, and it'd reduce the amount of patches I need to juggle until we get to a more recent version of Vitess. 😬

Related Issue(s)

#16085

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[harshit-gangal]

Unit Tests are failing, those need to be fixed as the test expectation about the query have changed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.25%. Comparing base (6fb0f0e) to head (f1f2596).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15715      +/-   ##
==========================================
+ Coverage   68.24%   68.25%   +0.01%     
==========================================
  Files        1543     1543              
  Lines      197577   197586       +9     
==========================================
+ Hits       134833   134863      +30     
+ Misses      62744    62723      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[arthurschreiber]

I'll create an issue for this (and link to it) shortly.