Add MySQL 8.4 unit tests #16440
Merged
Add MySQL 8.4 unit tests #16440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
force-pushed
the
mysql84-unit-tests
branch
3 times, most recently
from
ee7282d
to
9279fb3
Compare
MySQL 8.4 adds restrict_fk_on_non_standard_key for which the details can be found here: https://dev.mysql.com/doc/refman/8.4/en/server-system-variables.html#sysvar_restrict_fk_on_non_standard_key It prevents the use of non-unique keys or partial keys as foreign keys. For regular MySQL replication though, it does the following: Implication for MySQL Replication. When a foreign key is created on a nonstandard key on the primary because restrict_fk_on_non_standard_key is OFF, the statement succeeds on the replica regardless of any setting on the replica for this variable. Given how this works fir regular replication, we should mirror this behavior for vreplication and always allow this. So we set it up so we can do this with similar logic as to how we disable foreign key checks and we reset it back afterwards. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
force-pushed
the
mysql84-unit-tests
branch
from
9279fb3
to
0110468
Compare
In vitessio#7020 the logic was changed to always map YEAR to binary. But that is wrong, since this breaks the text protocol. Instead, we need to make sure that when we parse the binary data for prepared statements, we treat YEAR there as binary. That ensures we can parse it the way it's encoded in practice in the protocol (and not how it is documented). Signed-off-by: Dirkjan Bussink <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16440 +/- ##
==========================================
- Coverage 68.66% 68.65% -0.02%
==========================================
Files 1548 1549 +1
Lines 199124 199323 +199
==========================================
+ Hits 136731 136838 +107
- Misses 62393 62485 +92 ☔ View full report in Codecov by Sentry. |
There's some small changes for newer MySQL versions around typing information for certain functions etc. This adopts those changes for newer versions. Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
GrahamCampbell
suggested changes
Jul 23, 2024
dbussink
force-pushed
the
mysql84-unit-tests
branch
from
dfa4e32
to
dcfeef5
Compare
Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
force-pushed
the
mysql84-unit-tests
branch
from
dcfeef5
to
0f4b635
Compare
Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
added
Type: Enhancement
|
Didn't mark this specific one as needing release notes etc, since we only want to add those once we've completed the 8.4 stuff. |
dbussink
requested review from
GuptaManan100,
frouioui,
rohit-nayak-ps,
deepthi,
mattlord,
harshit-gangal,
shlomi-noach,
systay and
vmg
as code owners
frouioui
reviewed
Jul 23, 2024
I don't understand this comment? This only adds a CI job for MySQL 8.4 and doesn't do anything for Docker etc. yet. |
frouioui
reviewed
Jul 23, 2024
Comment on lines
+3
to
+7
| name: Unit Test (mysql84) | ||
| on: [push, pull_request] | ||
| concurrency: | ||
| group: format('{0}-{1}', ${{ github.ref }}, 'Unit Test (mysql84)') | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
FYI, we need to mark this workflow as required once the PR is merged.
frouioui
approved these changes
Jul 23, 2024
vmg
approved these changes
Jul 24, 2024
deepthi
reviewed
Jul 24, 2024
| @@ -42,8 +42,8 @@ type mysqlGRFlavor struct { | |||
| } | |||
|
|
|||
| // newMysqlGRFlavor creates a new mysqlGR flavor. | |||
| func newMysqlGRFlavor() flavor { | |||
| return &mysqlGRFlavor{} | |||
| func newMysqlGRFlavor(serverVersion string) flavor { | |||
There was a problem hiding this comment.
We should probably delete this file? WDYT?
venkatraju
pushed a commit
to slackhq/vitess
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to support MySQL 8.4 in the future, we need to run CI unit tests against it.
Part of #16466
Checklist