-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: don't treat join predicates as filter predicates #16472
Merged
harshit-gangal
merged 2 commits into
vitessio:main
from
planetscale:left-outer-condition
Jul 25, 2024
Merged
bugfix: don't treat join predicates as filter predicates #16472
harshit-gangal
merged 2 commits into
vitessio:main
from
planetscale:left-outer-condition
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
added
Type: Bug
Component: Query Serving
Backport to: release-18.0
Needs to be back ported to release-18.0
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
labels
Jul 25, 2024
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
July 25, 2024 07:02
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jul 25, 2024
Signed-off-by: Andres Taylor <[email protected]>
systay
force-pushed
the
left-outer-condition
branch
from
July 25, 2024 07:03
65c5771
to
1b2ed51
Compare
systay
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jul 25, 2024
Signed-off-by: Andres Taylor <[email protected]>
GuptaManan100
approved these changes
Jul 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16472 +/- ##
==========================================
- Coverage 68.65% 68.63% -0.02%
==========================================
Files 1551 1551
Lines 199468 199471 +3
==========================================
- Hits 136935 136904 -31
- Misses 62533 62567 +34 ☔ View full report in Codecov by Sentry. |
harshit-gangal
approved these changes
Jul 25, 2024
This was referenced Jul 25, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Andres Taylor <[email protected]>
systay
added a commit
that referenced
this pull request
Jul 29, 2024
…es (#16472) (#16475) Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Florent Poinsard <[email protected]> Co-authored-by: Andres Taylor <[email protected]>
systay
added a commit
that referenced
this pull request
Jul 30, 2024
…es (#16472) (#16473) Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andrés Taylor <[email protected]>
systay
added a commit
that referenced
this pull request
Jul 31, 2024
…es (#16472) (#16474) Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andrés Taylor <[email protected]>
venkatraju
pushed a commit
to slackhq/vitess
that referenced
this pull request
Aug 29, 2024
) Signed-off-by: Andres Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-18.0
Needs to be back ported to release-18.0
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
Component: Query Serving
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where we were treating join predicates as
WHERE
predicates by mistake.Related Issue(s)
Fixes #16471
Checklist