Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzer testing for 2PC transactions #16476

Merged
merged 11 commits into from
Jul 29, 2024

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Jul 25, 2024

Description

This PR adds the fuzzer tests for the 2PC transactions.

The testing strategy involves running many transactions and checking that they all must be atomic.
To this end, we have a very unique strategy. We have two sharded tables twopc_fuzzer_update, and twopc_fuzzer_insert with the following columns.

  • id: This is the sharding column. We use reverse_bits as the sharding vindex because it is easy to reason about where a row will end up.
  • col in twopc_fuzzer_insert: An auto-increment column.
  • col in twopc_fuzzer_update: This is a bigint value that we will use to increment on updates.
  • updateSet: This column will store which update set the inserts where done for.
  • threadId: It stores the thread id of the fuzzer thread that inserted the row.

The testing strategy is as follows -
Every transaction will do 2 things -

  • One, it will increment the col on 1 row in each of the shards of the twopc_fuzzer_update table.
    To do this, we have sets of rows that each map to one shard. We prepopulate this before the test starts.
    These sets are stored in the fuzzer in updateRowsVals.
  • Two, it will insert one row in each of the shards of the twopc_fuzzer_insert table and it will also store the update set that it updated the rows off.

We can check that a transaction was atomic by basically checking that the col value for all the rows that were updated together should match.
If any transaction was partially successful, then it would have missed an increment on one of the rows.
Moreover, the threadIDs of rows for a given update set in the 3 shards should be the same to ensure that conflicting transactions got committed in the same exact order.

Further Steps

The next steps are going to be to introduce thread level and cluster level disruptions to emulate failures that can happen during a real world system running, like PRS, a vttablet crashing, etc.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Jul 25, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 25, 2024
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 25, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.62%. Comparing base (88d7033) to head (745a491).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16476      +/-   ##
==========================================
- Coverage   68.63%   68.62%   -0.01%     
==========================================
  Files        1551     1551              
  Lines      199473   199515      +42     
==========================================
+ Hits       136906   136915       +9     
- Misses      62567    62600      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuptaManan100 GuptaManan100 merged commit fab9071 into vitessio:main Jul 29, 2024
129 checks passed
@GuptaManan100 GuptaManan100 deleted the fuzz-test-2pc branch July 29, 2024 13:36
venkatraju pushed a commit to slackhq/vitess that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants