Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulnerability fix #16613

Closed
wants to merge 1 commit into from
Closed

Conversation

harshitasao
Copy link
Contributor

Description

Fixed vulnerability reported by the scorecard.

Related Issue(s)

Part of #16607

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: harshitasao <[email protected]>
Copy link
Contributor

vitess-bot bot commented Aug 18, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 18, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Aug 18, 2024
@dbussink
Copy link
Contributor

@deepthi Should we instead remove vitess-mixin? Is it really used / maintained anymore at this point?

@mattlord
Copy link
Contributor

@deepthi Should we instead remove vitess-mixin? Is it really used / maintained anymore at this point?

I would vote to remove it. Nobody is actively maintaining it. People occasionally ask for help using it or ask why something doesn’t work but none of the active maintainers know anything about it.

@frouioui
Copy link
Member

I'd vote for the same.

@deepthi
Copy link
Member

deepthi commented Aug 26, 2024

@deepthi Should we instead remove vitess-mixin? Is it really used / maintained anymore at this point?

I would vote to remove it. Nobody is actively maintaining it. People occasionally ask for help using it or ask why something doesn’t work but none of the active maintainers know anything about it.

Yeah let's do that. We'll probably get people showing up and yelling about it. In which case we can ask for help maintaining it.

@dbussink dbussink mentioned this pull request Aug 27, 2024
5 tasks
@frouioui
Copy link
Member

I think it is safe to close this since #16657 was merged.

@frouioui frouioui closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants