Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unresolved Transactions command in vtctld service #16679

Merged
merged 9 commits into from
Sep 3, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Aug 29, 2024

Description

This PR adds support for vtcld server and vtctld client to provide unresolved distributed transactions list.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Aug 29, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 29, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 67.34694% with 32 lines in your changes missing coverage. Please review.

Project coverage is 68.93%. Comparing base (773a216) to head (e20b98a).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
go/cmd/vtctldclient/command/query.go 6.66% 14 Missing ⚠️
go/vt/vtctl/grpcvtctldclient/client_gen.go 0.00% 4 Missing ⚠️
go/vt/vtctl/grpcvtctldserver/server.go 86.66% 4 Missing ⚠️
go/vt/vtcombo/tablet_map.go 0.00% 2 Missing ⚠️
go/vt/vtctl/localvtctldclient/client_gen.go 0.00% 2 Missing ⚠️
go/vt/vttablet/faketmclient/fake_client.go 0.00% 2 Missing ⚠️
...t/vtctl/grpcvtctldserver/testutil/test_tmclient.go 75.00% 1 Missing ⚠️
go/vt/vttablet/grpctmclient/client.go 90.00% 1 Missing ⚠️
go/vt/vttablet/grpctmserver/server.go 85.71% 1 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_query.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16679      +/-   ##
==========================================
+ Coverage   68.92%   68.93%   +0.01%     
==========================================
  Files        1562     1565       +3     
  Lines      200941   201627     +686     
==========================================
+ Hits       138497   138994     +497     
- Misses      62444    62633     +189     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal harshit-gangal added Component: vtctl Component: vtctldclient and removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work labels Aug 29, 2024
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

eg.SetLimit(10)
for _, shard := range shards {
eg.Go(func() error {
si, err := s.ts.GetShard(newCtx, req.Keyspace, shard)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess using shard here is now safe with go1.23. I'm still wary of this!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was introduced in go1.21 as an experiment, and default use in go1.22

@harshit-gangal harshit-gangal merged commit dbbcd06 into vitessio:main Sep 3, 2024
132 checks passed
@harshit-gangal harshit-gangal deleted the vtctld-twopc branch September 3, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants